1. Unnecessary new()
Inpropriate:
DataSet ds = new DataSet();
ds = PageHelper.GetSignRecordDs(SubFormNo);
Modified:
DataSet ds = PageHelper.GetSignRecordDs(SubFormNo);
2. Throw
Inpropriate:
catch (Exception ex)
{
args.IsValid = false;
Logging.SaveLog(ELogLayer.UI, "ExchangeRateInit.aspx:CheckCSVFileValidation " + ex.Message, ELogType.Error);
throw ex;
}
Modified:
catch (Exception ex)
{
args.IsValid = false;
Logging.SaveLog(ELogLayer.UI, "ExchangeRateInit.aspx:CheckCSVFileValidation " + ex.Message, ELogType.Error);
throw;
}